Skip to content

Fix liquidity_abs undefined behavior#2473

Merged
sam0x17 merged 1 commit intodevnet-readyfrom
fix/liquidity_abs_undefined_behavior
Mar 10, 2026
Merged

Fix liquidity_abs undefined behavior#2473
sam0x17 merged 1 commit intodevnet-readyfrom
fix/liquidity_abs_undefined_behavior

Conversation

@gztensor
Copy link
Contributor

Description

liquidity_delta.abs() panics on i64::MIN

  • File: pallets/swap/src/pallet/impls.rs
  • Severity: Low
  • Status: Confirmed

liquidity_delta.abs() on a user-supplied i64 panics in debug / overflow-check builds when the value is i64::MIN. In production WASM release builds, wrapping semantics cause the value to fail the ensure check harmlessly. No production impact, but the code is undefined behavior-adjacent in debug builds.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Feb 27, 2026
@gztensor gztensor changed the base branch from main to devnet-ready February 27, 2026 21:15
@gztensor gztensor changed the title Fix/liquidity abs undefined behavior Fix liquidity_abs undefined behavior Feb 27, 2026
@gztensor gztensor removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Feb 27, 2026
@opentensor opentensor deleted a comment from github-actions bot Feb 27, 2026
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 10, 2026
@sam0x17 sam0x17 merged commit 7590f9d into devnet-ready Mar 10, 2026
189 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants